Bugfix: speedup interpolation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use an array view instead of a vector of PointXY's * use temporary arrays for longitude and latitude
Make the ostia_seaice_obs.yaml configuration match the current OPS comparision tests more closely.
twsearle
changed the title
s-good
approved these changes
Dec 17, 2021
Revert the change made to ostia_seaice_obs.yaml. I did this because this file is the only example of orcamodelHofX.x at the moment. I moved the test data to a new yaml file. We cannot add a test for this until atlas is updated to the latest version in jopa-bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The interpolation for 10 million sea ice observations takes over 3 hours.
Instructions to Reproduce the Issue
Run
orcamodel_hofx3D.xwith over 10000 observations in the input file. You can do this either using the comparison suite with Simon's branch, or by running using theostia_seaice_obs.yamlconfiguration.Acceptance Criteria (Definition of Done)
The interpolation of 10 million points takes less than 10 minutes.
Dependencies
max_fraction_elems_to_try = 0.0in the interpolation section of the configuration (the default is 0.2, and causes atlas to search 20% of the grid for points which lie outside of the model domain). An example of this setting is in L41 ofostia_seaice_obs.yaml.Summary of Changes
ostia_seaice_obs.yamlfile to point to a large example problemmax_fraction_elems_to_tryoption. Setting this to zero and using the head of atlas develop will cause the interpolator to skip observations that are not found in the cell with the closest cell centre or the 8 surrounding grid cells. See ecmwf::atlas#84 for details.