Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners file #103

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add codeowners file #103

merged 1 commit into from
Jul 9, 2024

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Jul 9, 2024

Description

The github CODEOWNERS file allows repository owners to specify owners of a repository or particular directories within a repo. This flexible approach allows automatic notification/addition of reviewers to pull requests relevant for that team or individual that is responsible for the repository. Later, we could add restrictions so that reviewers listed would have to accept the change before it could be merged, but I am not suggesting that right now.

Advantages:

  • guarantee that one of the reviewers has the ability to merge, meaning that we won't have any time between a change being marked accepted and merged.
  • the author of the PR would not have to figure out whose approval they need to get a change merged.

Issue(s) addressed

Experiment to implement suggestion in https://github.com/orgs/JCSDA-internal/discussions/144

@twsearle twsearle requested review from matthewrmshin and s-good July 9, 2024 09:39
@twsearle twsearle self-assigned this Jul 9, 2024
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps consider adding a deputy as well?

@twsearle
Copy link
Collaborator Author

twsearle commented Jul 9, 2024

Perhaps consider adding a deputy as well?

I can add you if you like, but at the moment this codeowners thing just makes sure I am added by default to every PR - very light touch. I don't really want to spam multiple people with emails when there is no need? I won't be required to accept the PR for it to be merged, so doesn't matter if I get hit by a bus! :) I agree though we would want something else if we require a review from a particular group. I am really only adding this as a demo - where I think it will be most useful is in ufo - we can say, add met office team as a codeowners for a bunch of met office checks just so they get automatically notified or add a global owner to make sure one person has a handle on merging the changes in at JCSDA. I see every PR come in on this repo anyway so I don't think this will make much difference... just playing around.

@matthewrmshin
Copy link
Collaborator

@twsearle Understood. All good as it is. 😄

@twsearle twsearle merged commit 0a26142 into develop Jul 9, 2024
2 checks passed
@twsearle twsearle deleted the feature/add-codeowners-file branch July 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants