-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read and write regular lat/lon atlas grids #102
Conversation
* Add factory pattern abstraction for AtlasIndex classes * Support indexing regular grids * Read server can read structured grids. * extend WriteServer to structured grids
Note, this PR is guaranteed to fail CI at this time. The change has been introduced to share and discuss issues with the results of the tests. When the tests pass, the PR will come out of draft. |
e5537e5
to
e48ccf5
Compare
9435cc3
to
2a85691
Compare
I took out the failing integration test and this looks to pass now so I have put it in review. I will shortly add links to sith comparison workflow runs for this change. |
Looks like there might be some issues with |
e006a95
to
3755d37
Compare
I think I have fixed the issue with the testing - I was accidentally using the atlas v0.38.1 KGO for my sith comparison tests. I also found the issue with the AMM tests - I was reading in the wrong observation file input! Apologies it took me so long to spot this (a lot of uncessary print statements) but on the bright side, I have interpolated a couple of the observations by hand so I am now quite convinced that this is working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks. I just left a few comments for you to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change and responding to my comments.
Description
Add reading and writing of regular latitude/longitude grid data.
Also includes:
Issue(s) addressed
Resolves #101
Dependencies
None at this time.
Impact
Enables multiple regional ocean model configurations in JOPA.
Testing checklist