Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on CI checking of indentation #100

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

s-good
Copy link
Collaborator

@s-good s-good commented Jun 27, 2024

Description

The lines in cpplint.py that check indentation were commented out so this wasn't being checked in the CI. This PR uncomments those lines and fixes the resulting errors.

Impact

None.

Checklist

  • I have updated the unit tests to cover the change
  • New functions are documented briefly via Doxygen comments in the code
  • I have linted my code using cpplint
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments: http://fcm1/cylc-review/taskjobs/hadgs/?suite=orca_jedi_indent

@s-good s-good marked this pull request as ready for review June 27, 2024 20:23
@s-good s-good requested a review from twsearle June 27, 2024 20:23
@s-good s-good self-assigned this Jun 27, 2024
Copy link
Collaborator

@twsearle twsearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@twsearle twsearle merged commit 6da4534 into develop Jun 28, 2024
2 checks passed
@twsearle twsearle deleted the feature/ci_indentation branch June 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants