Fix messageInputBar sendButton not disabled in some situations #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SD10
reviewed
Jan 24, 2018
| @@ -703,6 +703,5 @@ open class MessageInputBar: UIView { | |||
| /// Invalidates each of the inputManagers | |||
| open func didSelectSendButton() { | |||
| delegate?.messageInputBar(self, didPressSendButtonWith: inputTextView.text) | |||
| textViewDidChange() | |||
SD10
reviewed
Jan 24, 2018
| // MARK: - Notification | ||
|
|
||
| private func postTextViewDidChangeNotification() { | ||
| NotificationCenter.default.post(name: .UITextViewTextDidChange, object: self) |
There was a problem hiding this comment.
Do you think we need to post a notification here? What about keeping the behavior consistent with UIKit and just disabling the button in the didSet? I'm not saying this is the right approach. I want your opinion. cc @nathantannar4 please check this when you get a chance
There was a problem hiding this comment.
Emm, I think it needs. because besides adjust enabled of sendButton, we need also handle placeholderLabel,messageInputBar's size, and so on.
|
Looks fine Sent with GitHawk |
SD10
requested changes
Jan 24, 2018
There was a problem hiding this comment.
@zhongwuzw Care to add a CHANGELOG entry for this under bugfix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #473