Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/min fee ref script #344

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

twwu123
Copy link
Collaborator

@twwu123 twwu123 commented Oct 23, 2024

Summary

Conway era introduces fees for using ref script inputs. Unfortunately, even unused ref scripts are charged for, which is not accounted for in tx builder previously. I have updated the tx builder to account for such cases.

Affect components

Please indicate which part of the Mesh Repo

  • @meshsdk/common
  • @meshsdk/contract
  • @meshsdk/core
  • @meshsdk/core-csl
  • @meshsdk/core-cst
  • @meshsdk/provider
  • @meshsdk/react
  • @meshsdk/transaction
  • @meshsdk/wallet
  • Mesh playground (i.e. https://meshjs.dev/)
  • Mesh CLI

Type of Change

Please mark the relevant option(s) for your pull request:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Related Issues

Should close [#336]

Checklist

Please ensure that your pull request meets the following criteria:

  • My code is appropriately commented and includes relevant documentation, if necessary
  • I have added tests to cover my changes, if necessary
  • I have updated the documentation, if necessary
  • All new and existing tests pass (i.e. npm run test)
  • The build is pass (i.e. npm run build)

Additional Information

It is possible that with a bit of pushing, the Ledger can be updated so that unused ref scripts are not unnecessarily charged for. Maybe the Mesh community can push for this with a CIP proposal.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mesh-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 5:39am
mesh-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 5:39am

@twwu123 twwu123 linked an issue Oct 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fee calculation for tx "OracleValidator"
1 participant