Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new integer input editor with buttons + and - #2970

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Dec 19, 2023

image

    MMNumberEditor {
      title: "MMNumberEditor"
      number: 124
    }

@iiLubos iiLubos requested a review from tomasMizera December 19, 2023 12:34
Copy link

Pull Request Test Coverage Report for Build 7261854846

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 61.251%

Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/app/projectsmodel.cpp 1 67.23%
input/app/mmstyle.h 20 0.0%
Totals Coverage Status
Change from base Build 7258998059: -0.03%
Covered Lines: 7529
Relevant Lines: 12292

💛 - Coveralls

@tomasMizera
Copy link
Collaborator

Alter based on inputrangeeditable.qml

@iiLubos
Copy link
Contributor Author

iiLubos commented Dec 20, 2023

prepared to review

@tomasMizera tomasMizera merged commit 8f313be into master Dec 21, 2023
10 of 11 checks passed
@tomasMizera tomasMizera deleted the master_numberInput branch December 21, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants