-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up package #37
Tidy up package #37
Conversation
vignettes/base_char.rtf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file be output in "vignettes/outtable" folder?
This is related to Line #261 of vignettes/baseline-character.Rmd
.
@@ -221,7 +205,7 @@ x <- outdata |> | |||
format_disposition() | |||
|
|||
x$tbl <- x$tbl %>% | |||
mutate(name = ifelse(trimws(name) == "ZStatus Not Recorded", " Status Not Recorded", name)) | |||
mutate(name = ifelse(trimws(name) == "Status Not Recorded", " Status Not Recorded", name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this term is changed, the term in Line #77 also needs to be changed.
mutate(DCTREAS = ifelse(DISCONFL == "Y", DCREASCD, "ZStatus Not Recorded"))
vignettes/outtable/disposition.rtf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sample may be confused since the reason for discontinuation is displayed even under "Completed" and "Participants Ongoing".
It would be more realistic as sample data to set a value of DCTREAS (and DCSREAS for study discontinuation) only when EOTSTT1 is "discontinued" because DCTREAS is a variable of reason for discontinuation of treatment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for update. I have added some comments. Please check them.
clean up the package to pass build check and fix a bug