Merge pull request #55 from Merck/release-patch-2

Remove seed setting and replace `\dontrun{}` with `\donttest{}`
Merck · Dec 20, 2024 · f9f4612 · f9f4612
2 parents 46d69a2 + 10a01d3
commit f9f4612
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 4 deletions.
diff --git a/.Rbuildignore b/.Rbuildignore
@@ -8,4 +8,5 @@
 ^LICENSE_THIRD_PARTY\.md$
 ^\.github$
 ^codecov\.yml$
-^tests/testthat/_snaps$
+^tests/testthat/_snaps$
+^cran-comments\.md$
diff --git a/R/meta_sl_example.R b/R/meta_sl_example.R
@@ -179,7 +179,6 @@ meta_sl_exposure_example <- function() {
   adexsum$APERIODC <- "Base"
   adexsum$APERIOD <- 1
 
-  set.seed(123) # Set a seed for reproducibility
   adexsum$AVAL <- sample(x = 0:(24 * 7), size = length(adexsum$USUBJID), replace = TRUE)
   adexsum$EXDURGR <- "not treated"
   adexsum$EXDURGR[adexsum$AVAL >= 1] <- ">=1 day and <7days"

diff --git a/R/rtf_base_char_subgroup.R b/R/rtf_base_char_subgroup.R
@@ -31,7 +31,7 @@
 #' @export
 #'
 #' @examples
-#' \dontrun{
+#' \donttest{
 #' meta <- meta_sl_example()
 #'
 #' outdata <- prepare_base_char_subgroup(

diff --git a/cran-comments.md b/cran-comments.md
@@ -0,0 +1,6 @@
+## Resubmission v0.1.0
+
+This is a resubmission. In this version, I have fixed the issues identified in v0.1.0:
+
+-   Remove seed setting in `meta_sl_example()` to avoid to specify a seed in a function.
+-   Replace `\dontrun{}` with `\donttest{}` for an example of `rtf_base_char_subgroup()`.
diff --git a/man/rtf_base_char_subgroup.Rd b/man/rtf_base_char_subgroup.Rd
diff --git a/tests/testthat/test-independent-testing-rtf_exp_duration.R b/tests/testthat/test-independent-testing-rtf_exp_duration.R
@@ -1,5 +1,6 @@
 library(metalite)
 
+set.seed(123)
 metatest <- meta_sl_exposure_example()
 
 outdata <- prepare_sl_summary(