Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore operator quotations and update to roxygen2 7.3.1 #327

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

nanxstats
Copy link
Collaborator

@nanxstats nanxstats commented Jan 26, 2024

This PR reverts the changes in #314 by adding the quotes back as the parser bug in roxygen2 7.3.0 has been fixed in roxygen2 7.3.1 (on CRAN 2024-01-22), and reran roxygen2 to update the RoxygenNote field in DESCIRPTION to use 7.3.1.

Changing this back ensures the convention to import special operators like := or %>% is consistent with both

  1. The generated NAMESPACE file in this package.
  2. All other packages that have been quoting them all along.

so I think this is worth it.

@nanxstats nanxstats requested a review from jdblischak January 26, 2024 23:01
@nanxstats
Copy link
Collaborator Author

Note that although running this using roxygen2 7.3.0 will result in those parsing errors, this message will be shown at the top:

ℹ Updating gsDesign2 documentation
✖ Installed roxygen2 is older than the
  version used with this package
ℹ You have "7.3.0" but you need "7.3.1"

which tells people what to do - upgrade.

@nanxstats nanxstats merged commit ee9d142 into main Jan 27, 2024
8 checks passed
@nanxstats nanxstats deleted the roxygen-quotes branch January 27, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants