Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define event_diff() as a separate internal function #312

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jdblischak
Copy link
Collaborator

Motivation: #235 (comment)

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jdblischak , thanks for the updates! I only have 1 minor comment below.

R/expected_time.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I appreciate this refactor that makes expected_time() more robust.

@nanxstats nanxstats merged commit ff5dbb6 into Merck:main Jan 16, 2024
8 checks passed
@jdblischak jdblischak deleted the event_diff branch January 16, 2024 21:12
@jdblischak jdblischak self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants