Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update arguments #57

Merged
merged 3 commits into from
Jul 3, 2024
Merged

update arguments #57

merged 3 commits into from
Jul 3, 2024

Conversation

wangben718
Copy link
Collaborator

No description provided.

@wangben718 wangben718 linked an issue Jul 2, 2024 that may be closed by this pull request
release v0.1.1 #56
Closed
22 tasks
yuliasidi
yuliasidi approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@yuliasidi yuliasidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In prepare_ae_forestly() it is not clear what are the options for components and what each option means. I understand that this argument is inherited from metalite.ae::prepare_ae_specific(). Perhaps clarifying it there could help?

@wangben718 wangben718 merged commit 7d9720c into main Jul 3, 2024
7 checks passed
@nanxstats
Copy link
Collaborator

In prepare_ae_forestly() it is not clear what are the options for components and what each option means. I understand that this argument is inherited from metalite.ae::prepare_ae_specific(). Perhaps clarifying it there could help?

Perhaps the original intention is to make people guess, try everything, and figure it out themselves... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliasidi yuliasidi yuliasidi approved these changes

@LittleBeannie LittleBeannie LittleBeannie approved these changes

@elong0527 elong0527 Awaiting requested review from elong0527

@nanxstats nanxstats Awaiting requested review from nanxstats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release v0.1.1
4 participants
@wangben718 @nanxstats @yuliasidi @LittleBeannie