Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Mahalanobis distance (#6) #7

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

thevolatilebit
Copy link
Collaborator

@thevolatilebit thevolatilebit commented Nov 23, 2023

Added the option to use a Mahalanobis distance to compute distance between readout vectors. Update tests.

Also updated DistanceBased so that it is no more assumed that the distance is just the sum of column-wise distances. Keyword distances replaced by distance.

Prioritizing keyword arguments for method signatures in GenerativeDesigns.

Added the option to use a Mahalanobis distance to compute distance
between readout vectors. Update tests.

Also updated `DistanceBased` so that it is no more assumed that the
distance is just the sum of column-wise distances. Keyword `distances`
replaced by `distance`.
@thevolatilebit thevolatilebit added the enhancement New feature or request label Nov 23, 2023
@thevolatilebit thevolatilebit self-assigned this Nov 23, 2023
@thevolatilebit thevolatilebit linked an issue Nov 23, 2023 that may be closed by this pull request
Copy link
Collaborator

@danielchen26 danielchen26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thevolatilebit I have some comments on the function naming and am suggesting a refactored code for Mahalanobis distance. Let me know if it makes sense.

tutorials/GenerativeDesigns.jl Outdated Show resolved Hide resolved
docs/src/tutorials/GenerativeDesigns.jl Show resolved Hide resolved
src/GenerativeDesigns/distancebased.jl Show resolved Hide resolved
docs/src/tutorials/GenerativeDesigns.jl Show resolved Hide resolved
@thevolatilebit thevolatilebit merged commit 323fc2e into main Nov 28, 2023
3 checks passed
@thevolatilebit thevolatilebit deleted the add-mahalanobis branch November 28, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Mahalanobis distance
2 participants