Properly handle paths #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @MelvinVermeer, any chance you could review and release? 🙏 |
|
@MelvinVermeer 👋 😅 |
|
Would be great to get this merged, as I spent quite some time debugging today why VS Code and CLI reported different eslint issues related to import paths. After some digging, I came to thix exact conclusion and fix 😅 I should have checked github issues first... 🙃 |
|
I'm using |
|
@MelvinVermeer Any chance of getting this reviewed/merged? 😊 |
|
@MelvinVermeer merge plz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
This bug was preventing VSCode ESLint extension to properly report the rule's error.
I also removed logic about defaulting
rootDirto""as it's already done when reading the context's options.