Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fail early if private_key_path doesn't exist #326

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

kronnk
Copy link
Contributor

@kronnk kronnk commented Mar 6, 2025

This pull request includes an important update to the get_private_key method in the target_snowflake/connector.py file. The changes enhance logging and error handling when reading the private key from a file.

Enhancements to logging and error handling:

  • Added a debug log statement to indicate when the private key is being read from a file.
  • Introduced a check to verify if the private key file exists before attempting to read it, raising a FileNotFoundError with a descriptive error message if the file is not found.

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edgarrmondragon edgarrmondragon changed the title fix: handle FileNotFound for private_key_path fix: Fail early if private_key_path doesn't exist Mar 6, 2025
@edgarrmondragon edgarrmondragon merged commit bb1e9d5 into MeltanoLabs:main Mar 6, 2025
2 of 10 checks passed
@edgarrmondragon edgarrmondragon self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants