Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make tunnel settings optional #136

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: make tunnel settings optional #136

merged 1 commit into from
May 25, 2023

Conversation

pnadolny13
Copy link
Contributor

Closes #135

@pnadolny13 pnadolny13 changed the title make tunnel settings optional fix: make tunnel settings optional May 24, 2023
edgarrmondragon
edgarrmondragon approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be improved by meltano/sdk#1525

@pnadolny13 pnadolny13 merged commit 7c30720 into main May 25, 2023
@pnadolny13 pnadolny13 deleted the fix_tunnel_settings_optional branch May 25, 2023 14:22
@pnadolny13 pnadolny13 mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

@visch visch Awaiting requested review from visch

@kgpayne kgpayne Awaiting requested review from kgpayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ConfigValidationError when ssh_tunnel disabled
2 participants
@pnadolny13 @edgarrmondragon