Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with the repo_id type for user streams being incorrect #255

Conversation

BraedonLeonard
Copy link
Contributor

The schema would report repo_id as a string, which caused validation errors when running since repo_id is actually an integer.

The schema would report repo_id as a string, which caused validation errors when running since repo_id is actually an integer
@BraedonLeonard BraedonLeonard changed the title Fix issue with the repo_id type for user streams being incorrect fix: Fix issue with the repo_id type for user streams being incorrect Jun 5, 2024
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@edgarrmondragon
Copy link
Member

This does make sense but it might introduce a breaking change :(

@BraedonLeonard
Copy link
Contributor Author

BraedonLeonard commented Jul 16, 2024

This does make sense but it might introduce a breaking change :(

Do you have any ideas on how this change could get introduced without being a breaking change? Or at least a similar change that solves the issue of schema validation failing for every message in the starred repo stream

@edgarrmondragon
Copy link
Member

This does make sense but it might introduce a breaking change :(

Do you have any ideas on how this change could get introduced without being a breaking change? Or at least a similar change that solves the issue of schema validation failing for every message in the starred repo stream

On a second look, this should actually be more or less a safe change, and a necessary one. If a column in the destination exists with a TEXT type, then it should be happy to accept an integer literal and cast it automatically.

I'm merging it :)

@edgarrmondragon edgarrmondragon merged commit ba25c4f into MeltanoLabs:main Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants