Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphql pagination #168

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Fix graphql pagination #168

merged 6 commits into from
Nov 22, 2022

Conversation

ericboucher
Copy link
Contributor

@ericboucher ericboucher commented Nov 22, 2022

Fixes #165 by iterating through pagination cursors with the same index if the first ones are null, and making sure that we properly reset pagination cursor for higher indices

@ericboucher ericboucher requested a review from laurentS November 22, 2022 11:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericboucher ericboucher merged commit efab218 into main Nov 22, 2022
@ericboucher ericboucher deleted the graphql-pag branch November 22, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination in graphql streams seems broken
2 participants