Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.11 #162

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Add support for python 3.11 #162

merged 4 commits into from
Nov 8, 2022

Conversation

laurentS
Copy link
Contributor

Just adds a run with the newly released python 3.11. Hopefully everything should run smoothly 🎿 !

@laurentS laurentS requested a review from ericboucher October 26, 2022 13:08
@laurentS
Copy link
Contributor Author

The tests are a bit cheeky (from the logs of the python 3.11 execution):

The currently activated Python version 3.11.0 is not supported by the project (<3.11,>=3.7.2).
Trying to find and use a compatible version. 
Using python3.8 (3.8.10)

@laurentS
Copy link
Contributor Author

This PR cannot be fixed until the sdk is upgraded to support python 3.11.
Right now poetry update fails with the following error:

The current project's Python requirement (>=3.7.2,<3.12) is not compatible with some of the required packages Python requirement:
  - singer-sdk requires Python >=3.7.1,<3.11, so it will not be satisfied for Python >=3.11,<3.12
  - singer-sdk requires Python >=3.7.1,<3.11, so it will not be satisfied for Python >=3.11,<3.12

Because no versions of singer-sdk match >0.12.0,<0.13.0 || >0.13.0
 and singer-sdk (0.12.0) requires Python >=3.7.1,<3.11, singer-sdk is forbidden.
So, because singer-sdk (0.13.0) requires Python >=3.7.1,<3.11
 and tap-github depends on singer-sdk (>=0.12.0), version solving failed.

Waiting on meltano/sdk#1115

@ericboucher
Copy link
Contributor

@laurentS shouldn't the tests be failing then?

@laurentS
Copy link
Contributor Author

@laurentS shouldn't the tests be failing then?

Sorry, I realise my messages were confusing. Basically CI passes because poetry falls back to python 3.8 in the 3.11 run. The error in my last message was from a run on my machine after adjusting the pyproject.toml file and trying to resolve dependencies again with poetry update (which does not happen in CI).

So I think we don't have too many options, wait for sdk which is waiting on pyarrow. Their build is passing as of 2h ago, so it shouldn't take too long before they push a new release.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ericboucher ericboucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until we have a stable release for the SDK :)

@laurentS
Copy link
Contributor Author

laurentS commented Nov 8, 2022

Let's wait until we have a stable release for the SDK :)

Done, using sdk 0.13.1 now, which includes python 3.11 support, despite what the release notes say.

@laurentS laurentS changed the title Add python 3.11 to CI workflows Add support for python 3.11 Nov 8, 2022
@laurentS laurentS merged commit ed58c6b into main Nov 8, 2022
@laurentS laurentS deleted the add-python-311-to-ci branch November 8, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants