Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team parents ("parent" is an object) #134

Merged
merged 31 commits into from
May 20, 2022
Merged

Fix team parents ("parent" is an object) #134

merged 31 commits into from
May 20, 2022

Conversation

SBurwash
Copy link
Contributor

Copy of PR#133 fix team parents + Rebase from @ericboucher

ericboucher and others added 30 commits May 17, 2022 22:50
@ericboucher
initialization graphql stargazers
7d90097
@ericboucher
Fix stargazers query
0440ec0
@ericboucher
simplify query
89bb766
@ericboucher
Update repository_streams.py
348f303
@ericboucher
Add early exit with fake "since"
42310c8
@ericboucher
Add new stream and order alphabetically
ed77f27
@ericboucher
Add missing user params
3977dee
@ericboucher
Test different path for api_calls_tests_cache
eec8d3d
@ericboucher
Retry pytest once on error
3b8e9b3
@ericboucher
Fix push target in github action
f46c2e1
@ericboucher
Update test_tap.yml
6ee2765
@ericboucher
Update test_tap.yml
7d43ea6
@ericboucher
Update test_tap.yml
2b433c6
@ericboucher
Update test_tap.yml
8ad4f69
@ericboucher
Use alternative_sync_chidren in tap_core
5b5b64c
@ericboucher
Update test_tap.yml
9e0dd6d
@ericboucher
Update test_tap.yml
6c58936
@ericboucher
Update test_tap.yml
0bb3531
@ericboucher @laurentS
Update tap_github/tests/fixtures.py
b58691a 
Co-authored-by: Laurent Savaete <laurent@where.tf>
@ericboucher
Override REST stream
288dd81
@ericboucher
Update repository_streams.py
dc52830
@ericboucher
Update test_tap.yml
79d1970
@SBurwash
Removed gitingore in secrets + added vscode in ide
62d3416
@SBurwash
Chnaged parents structure teams
5e13c0b
@ericboucher
Revert "Override REST stream"
443825b 
This reverts commit 288dd81.
@ericboucher
Keep both streams but add warning
1c79c06
@SBurwash
Added back gitignore in secrets
3def2b9
@SBurwash
Ran formating
90d5fca
@ericboucher
Update repository_streams.py
862e7ca
@ericboucher
Merge branch 'stargazers-graphql' into pr/132
38be6bf
@ericboucher ericboucher self-requested a review May 20, 2022 14:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericboucher ericboucher changed the title Fix team parents Fix team parents ("parent" is now an object) May 20, 2022
@ericboucher ericboucher changed the title Fix team parents ("parent" is now an object) Fix team parents ("parent" is an object) May 20, 2022
@ericboucher ericboucher merged commit c0d7b45 into MeltanoLabs:main May 20, 2022
@ericboucher ericboucher deleted the fix-team-parents branch May 20, 2022 14:39
@ericboucher
Copy link
Contributor

Thanks @SBurwash for your first contribution!

@ericboucher ericboucher linked an issue May 24, 2022 that may be closed by this pull request
Teams endpoint parent changed #130
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericboucher ericboucher ericboucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teams endpoint parent changed
2 participants
@SBurwash @ericboucher