Fix user verification query and accept organization logins #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericboucher
approved these changes
May 9, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
ericboucher
changed the title
ericboucher
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users stream is giving unexpected results for organizations as the graphql endpoint is very picky about the user type and won't give any info for orgs.
This PR uses a different
repositoryOwnerquery to cover both user and organization user types while enriching the config provided usernames.It is a bit hacky because the API does not include the
databaseIdfor this query, so we parse it from a url :/