Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singer dependencies #50

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Fix singer dependencies #50

merged 3 commits into from
Oct 4, 2022

Conversation

astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Oct 4, 2022 •
edited
Loading

Fix gh-48, fix gh-49 by implementing the first + second strategy.

@astrojuanlu
Copy link
Contributor Author

⛔

ERROR: Cannot install meltano-map-transform because these package versions have conflicting dependencies.

The conflict is caused by:
    pipelinewise-singer-python 1.2.0 depends on jsonschema==3.2.0
    singer-sdk 0.11.1 depends on jsonschema<5.0.0 and >=4.16.0

Back to square one.

@astrojuanlu astrojuanlu marked this pull request as draft October 4, 2022 10:02
@astrojuanlu astrojuanlu mentioned this pull request Oct 4, 2022
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@astrojuanlu
Copy link
Contributor Author

This fixed the installation problems 👍🏽

@astrojuanlu astrojuanlu marked this pull request as ready for review October 4, 2022 10:23
edgarrmondragon
edgarrmondragon approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @astrojuanlu!

@edgarrmondragon edgarrmondragon merged commit 7650d27 into MeltanoLabs:main Oct 4, 2022
@astrojuanlu astrojuanlu deleted the fix-singer-deps branch October 4, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing singer dependency Project version does not match git tag
2 participants
@astrojuanlu @edgarrmondragon