Use enums for representing the state of a figure #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums provide the benefit of not being prone to accidental changes by a programmer who sets the boolean flags previously used by
Figure
in a wrong manner, similar to this:This can be a real problem, because a figure can never be in its house and in its base at the same time!
Since enums either take one value or another, this problem can easily be prevented. It also serves to produce much cleaner code, which I have amplified by moving this logic to the class
Figure
, which should be responsible for managing its own state.