Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation enhancement: Horizontally center Check component in Horizontal Field #3775

Closed
oaldrian opened this issue May 8, 2022 · 2 comments
Labels
Area: Documentation Something is missing in the documentation. Status: Not Planned

Comments

@oaldrian
Copy link
Contributor

oaldrian commented May 8, 2022

Is your feature request related to a problem? Please describe.

This is a Documentation enhancement request, but I can only create a Issue type Feature Request

When using a horizontal Field with a Check component as FieldBody the checkbox is not centered horizontally but slightly upwards in comparison to the FieldLabel.

To Reproduce
Steps to reproduce the behavior:

Use following code on a page

<Field Horizontal>
         <FieldLabel ColumnSize="ColumnSize.Is5">Abgeschlossen</FieldLabel>
         <FieldBody ColumnSize="ColumnSize.Is7">
           <Check TValue="bool" />
         </FieldBody>
       </Field>

Describe the solution you'd like
Either under Check or under Field in the documentation it should be mentioned that this behavior can be mitigated with putting Margin="Margin.IsAuto" on the FieldBody.

Like this

 <Field Horizontal>
          <FieldLabel ColumnSize="ColumnSize.Is5">Abgeschlossen</FieldLabel>
          <FieldBody Margin="Margin.IsAuto" ColumnSize="ColumnSize.Is7">
            <Check TValue="bool" />
          </FieldBody>
        </Field>

Additional context

This only happens to the Check component to my knowledge, and as the other components behaved "normal" aka horizontally centered, I think it is worth mentioning it in the docu.

@oaldrian oaldrian added the Type: Feature ⚙ Request or idea for a new feature. label May 8, 2022
@oaldrian
Copy link
Contributor Author

oaldrian commented May 8, 2022

If this "feature" gets a go from you, I will "implement" it into the doc.

@stsrki
Copy link
Collaborator

stsrki commented May 9, 2022

It's because the check doesn't have the same height by default as other inputs do. Yeah, you can add it to the docs. Just make sure you're working on/from the right branch. You can make it on rel-1.0.0.

@stsrki stsrki added Area: Documentation Something is missing in the documentation. and removed Type: Feature ⚙ Request or idea for a new feature. labels May 9, 2022
stsrki added a commit that referenced this issue May 25, 2022
* add missing PageSizeChanged EventHandler in DataGrid attributes list

* add description and example for horizontal Field with Check component (#3775)

* Recompile field example

* Formating

* Rephrase the example

Co-authored-by: Mladen Macanovic <mladen.macanovic@gmail.com>
@stsrki stsrki closed this as completed Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Something is missing in the documentation. Status: Not Planned
Projects
None yet
Development

No branches or pull requests

2 participants