Added Fallback for AtB Bonus Unit Creation. #5911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved error handling in `getTankEntity` by checking for null roles and logging more informative messages. Enhanced `AtBContract` unit generation with a fallback mechanism to retry creation if the initial attempt fails.
Refactored the bonus unit generation process to streamline faction and quality determination. Implemented a fallback mechanism with the campaign's faction if the initial generation fails. Improved readability and reduced redundant code for better maintainability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5911 +/- ##
============================================
- Coverage 10.29% 10.29% -0.01%
+ Complexity 6128 6125 -3
============================================
Files 1038 1038
Lines 139161 139210 +49
Branches 20612 20622 +10
============================================
+ Hits 14329 14334 +5
- Misses 123424 123468 +44
Partials 1408 1408 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtBContractbonus unit generation with a fallback mechanism to retry creation if the initial attempt fails.getTankEntityby checking for null roles and logging more informative messages.Fix #5910