Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Internal Dissension Events in StratCon #5889

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Adjusted the logic for Internal Dissension events to account for StratCon-enabled campaigns.
  • Added a support point penalty if StratCon is active, while maintaining the original behavior for non-StratCon campaigns.

This ensures all AtB Special Scenarios will not spawn for StratCon enabled campaigns.

Adjusted the logic for Internal Dissension events to account for StratCon-enabled campaigns. Added a support point penalty if StratCon is active, while maintaining the original behavior for non-StratCon campaigns. This ensures compatibility with StratCon mechanics.
@IllianiCBT IllianiCBT added AtB StratCon Bugs relating strictly to StratCon Legacy Improvement Improves a legacy setup's handling. labels Jan 26, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.31%. Comparing base (765c7bd) to head (d12c62e).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5889      +/-   ##
============================================
+ Coverage     10.30%   10.31%   +0.01%     
- Complexity     6129     6140      +11     
============================================
  Files          1038     1038              
  Lines        139154   139159       +5     
  Branches      20609    20611       +2     
============================================
+ Hits          14335    14351      +16     
+ Misses       123424   123418       -6     
+ Partials       1395     1390       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT added the Bug label Jan 26, 2025
@IllianiCBT IllianiCBT merged commit 474f69e into MegaMek:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AtB Bug Legacy Improvement Improves a legacy setup's handling. StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants