Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolled Back Window Size Setting #5875

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

IllianiCBT
Copy link
Collaborator

Discussed with Luana and she advised to just remove it rather than exploring other options.

Removed the code that maximized the main window on startup. This allows the application to honor the specified preferred and minimum dimensions for the main frame. Improves flexibility for users with different screen sizes.
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.28%. Comparing base (5b5d337) to head (2d73731).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5875      +/-   ##
============================================
- Coverage     10.30%   10.28%   -0.03%     
+ Complexity     6136     6116      -20     
============================================
  Files          1038     1038              
  Lines        139139   139154      +15     
  Branches      20603    20610       +7     
============================================
- Hits          14345    14312      -33     
- Misses       123407   123437      +30     
- Partials       1387     1405      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 5b456f7 into MegaMek:master Jan 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants