Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makes the preset dialog show up properly in Linux and adjusts th… #5834

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

firefly2442
Copy link
Contributor

…e dropdown so it's not cutoff, addresses issue: #3701

This fixes two items:

  • First is issue New campaig hangs #3701. This also keeps the main menu visible until you make some selections for the preset. I tried multiple other avenues, this was the only way I was able to get it to show up properly. I only tested with Linux (PopOS). Someone may want to check this on Windows.
  • The dropdown for the presets was getting cutoff. See screenshot:

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.32%. Comparing base (bd33354) to head (11584dd).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5834      +/-   ##
============================================
- Coverage     10.32%   10.32%   -0.01%     
- Complexity     6127     6132       +5     
============================================
  Files          1037     1038       +1     
  Lines        138670   138780     +110     
  Branches      20521    20538      +17     
============================================
+ Hits          14321    14328       +7     
- Misses       122958   123066     +108     
+ Partials       1391     1386       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 1b7b452 into MegaMek:master Jan 22, 2025
4 checks passed
@firefly2442 firefly2442 deleted the loading-preset-bug branch January 22, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants