Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Bounds Calculation in getUnoccupiedAdjacentCoords #5785

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Reduced track width and height by one to account for zero-based indexing in coordinate calculations.

Fix #5779

Reduced track width and height by one to account for zero-based indexing in coordinate calculations. This change ensures accurate boundary checks and prevents potential out-of-bounds errors.
@IllianiCBT IllianiCBT added Bug StratCon Bugs relating strictly to StratCon labels Jan 15, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.19%. Comparing base (fd739ba) to head (3b3df3d).
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5785      +/-   ##
============================================
- Coverage     10.21%   10.19%   -0.02%     
+ Complexity     6076     6059      -17     
============================================
  Files          1010     1010              
  Lines        139310   139310              
  Branches      20448    20448              
============================================
- Hits          14231    14206      -25     
- Misses       123703   123729      +26     
+ Partials       1376     1375       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit ae958c7 into MegaMek:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug StratCon Bugs relating strictly to StratCon
Projects
None yet
3 participants