fix: compilation error due to a function being set as static but acessing instance data #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing instance data
IllianiCBT
approved these changes
Jan 9, 2025
|
I just realised you already solved the problem by making the property static. I dont know if thats the best way to deal with it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5735 +/- ##
============================================
+ Coverage 10.19% 10.21% +0.01%
- Complexity 6062 6076 +14
============================================
Files 1010 1010
Lines 139310 139310
Branches 20448 20448
============================================
+ Hits 14204 14231 +27
+ Misses 123734 123703 -31
- Partials 1372 1376 +4 ☔ View full report in Codecov by Sentry. |
|
I can confirm it was not. |
IllianiCBT
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: compilation error due to a function being set as static but acessing instance data