Feat/acar v2 #5699
Merged
Feat/acar v2 #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acar, fix for formation values and player name on acar
…upForces from an abstract class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5699 +/- ##
============================================
+ Coverage 10.03% 10.21% +0.17%
- Complexity 6067 6079 +12
============================================
Files 1074 1009 -65
Lines 141645 139358 -2287
Branches 20645 20416 -229
============================================
+ Hits 14212 14230 +18
+ Misses 126064 123756 -2308
- Partials 1369 1372 +3 ☔ View full report in Codecov by Sentry. |
IllianiCBT
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the entire ACAR module to megamek, updates MekHQ to use new ACAR dialogs for combat resolution