Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SP Cost for GM Reinforcement Attempts in StratCon #5693

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Removed SP cost when using Reinforce (GM) option in StratCon.

Removed unnecessary calculations and Support Point cost deduction for GM reinforcement attempts. Updated tooltip to reflect bypass of both reinforcement checks and Support Point costs. This clarifies and streamlines GM-specific functionality.
@IllianiCBT IllianiCBT added StratCon Bugs relating strictly to StratCon UX User experience labels Jan 7, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.03%. Comparing base (4cf3be1) to head (e8820f4).
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5693   +/-   ##
=========================================
  Coverage     10.02%   10.03%           
+ Complexity     6068     6066    -2     
=========================================
  Files          1074     1074           
  Lines        141641   141638    -3     
  Branches      20645    20645           
=========================================
+ Hits          14206    14209    +3     
+ Misses       126063   126058    -5     
+ Partials       1372     1371    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 4495c68 into MegaMek:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
StratCon Bugs relating strictly to StratCon UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants