Added Potential Difficulty Spikes to Garrison-Type Contracts #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored morale adjustments to introduce variable morale levels, improving dynamic contract outcomes. Added logic to regenerate scenario odds for StratCon-enabled contracts, incorporating multipliers for higher intensity scenarios. Replaced redundant calls to `Compute.randomInt` with `randomInt` for consistency.
Standardized morale level updates and clarified Garrison contract checks by replacing `isGarrisonType` with `isGarrisonDuty` for consistency. Adjusted morale logic, randomization, and scenario odds processing to improve code accuracy and readability. Updated tooltip text to better describe a Garrison state scenario.
Previously, enemy updates were applied universally during morale changes. Added a condition to limit updates to garrison contracts that are not riot duty, ensuring more accurate behavior. This prevents unintended changes in scenarios outside the specified contract types.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5690 +/- ##
=========================================
Coverage 10.02% 10.03%
- Complexity 6068 6069 +1
=========================================
Files 1074 1074
Lines 141641 141659 +18
Branches 20645 20652 +7
=========================================
+ Hits 14206 14209 +3
- Misses 126063 126081 +18
+ Partials 1372 1369 -3 ☔ View full report in Codecov by Sentry. |
Sleet01
reviewed
Jan 9, 2025
| // This works with the regenerated Scenario Odds to crease very high intensity | ||
| // spikes in otherwise low-key Garrison-type contracts. | ||
| AtBMoraleLevel newMoraleLevel = switch (roll) { | ||
| case 0,1 -> AtBMoraleLevel.STALEMATE; |
There was a problem hiding this comment.
This format makes these tables so much cleaner!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5689