Refactored Crew Assignment Event Handling #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardized variable naming for clarity, improved `PersonCrewAssignmentEvent` to include context of associated campaigns, and ensured force commander updates during crew assignments. Enhanced readability and maintainability across related methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5682 +/- ##
============================================
+ Coverage 10.02% 10.04% +0.01%
- Complexity 6068 6075 +7
============================================
Files 1074 1074
Lines 141641 141646 +5
Branches 20645 20647 +2
============================================
+ Hits 14206 14225 +19
+ Misses 126063 126051 -12
+ Partials 1372 1370 -2 ☔ View full report in Codecov by Sentry. |
Updated copyright notices in Unit.java and PersonCrewAssignmentEvent.java to reflect the new year. This ensures compliance with licensing and accurate attribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PersonCrewAssignmentEventto update the commander data of any associated forces.Fix #5681