Expanded and Fixed Cargo Capacity Logic #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted and centralized cargo capacity parsing into a dedicated method to improve code clarity and reusability. Updated patterns and logic to account for edge cases, including localization variations. Enhanced error handling and logging for parsing issues.
Replaced repeated `Math.max` calls with static imports for better readability. Refactored `getCargoCapacity` to improve clarity and accuracy by simplifying logic and removing redundant code. The changes streamline computations and enhance maintainability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5673 +/- ##
=========================================
Coverage 10.02% 10.03%
- Complexity 6067 6072 +5
=========================================
Files 1074 1074
Lines 141598 141664 +66
Branches 20645 20654 +9
=========================================
+ Hits 14201 14216 +15
- Misses 126024 126076 +52
+ Partials 1373 1372 -1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mountedrather than string comparison. This should make it a lot more durable to change. This should fix [50.02] ClassCastException on manuel game resolve #5648, however as that appears to be a localization issue I cannot be certain.