Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked Morale Logic #5669

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

IllianiCBT
Copy link
Collaborator

  • Updated morale determination to remove extreme shifts. Now morale will only ever make one step in either direction. The -/+ 2 behavior was a holdover from the AtB Morale system and really should have been removed when morale was reworked a couple months ago.
  • Added specific handling of "refused engagement" scenario states. These now count as decisive defeats, as the enemy is completely unopposed and able to achieve their objective with ease.
  • Introduced a player-facing morale level for garrison contracts displaying peaceful morale when routed. This will remove any potential confusion resulting from Garrison-type contracts starting with 'routed' morale (working as intended). We set Garrison-type contracts as Routed, so Garrison-type contracts don't feel like you're facing a full-scale planetary invasion from day one. This is a cosmetic change only.
  • Removed 'confidence' modifier. This created a poor interaction when there was a large disparity between the skill level of opposing and allied forces and is better handled by the reliability modifier anyway. By removing 'confidence' we place a higher emphasis on victories and defeats.
  • Reduced the impact of 'Reliability' modifiers.
  • Reduced the impact of 'Performance' modifiers. These modifiers were previously increased to account for the other potential stacking modifiers. That is no longer necessary due to the removal of confidence modifiers and the reduction of reliability modifiers.
  • Updated documentation to account for these changes.

Fix #5667

Updated morale determination to remove extreme shifts and refined the handling of "refused engagement" scenarios. Introduced a specialization for garrison contracts displaying peaceful morale when routed. Simplified confidence calculations with a dedicated clan overconfidence modifier.
Added `isRefusedEngagement` as a condition for `isOverallDefeat`. This ensures that scenarios marked with refused engagement are correctly classified as overall defeats.
The Clan Overconfidence modifier logic was removed from AtBContract.java, simplifying morale calculations. This change eliminates unused or unnecessary functionality to streamline the codebase and logging details. No other functionality was affected.
Revised the dragoon rating reliability computation by reducing conditions, consolidating similar cases, and simplifying logic. Adjusted performance modifiers for victories and defeats to reduce the impact, ensuring more balanced gameplay adjustments.
@IllianiCBT IllianiCBT added Bug AtB StratCon Bugs relating strictly to StratCon Documentation labels Jan 6, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.03%. Comparing base (be04339) to head (46ca5fe).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5669   +/-   ##
=========================================
  Coverage     10.02%   10.03%           
- Complexity     6067     6071    +4     
=========================================
  Files          1074     1074           
  Lines        141598   141642   +44     
  Branches      20645    20643    -2     
=========================================
+ Hits          14201    14217   +16     
- Misses       126024   126055   +31     
+ Partials       1373     1370    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 26939fd into MegaMek:master Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AtB Bug Documentation StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immediate Routed status
3 participants