fix: keep odd number checks using modulus, however, make sure they wi…

[firefly2442]

…ll work for negative numbers as well, found via SpotBugs

Check for oddness that won't work for negative numbers The code uses x % 2 == 1 to check to see if a value is odd, but this won't work for negative numbers (e.g., (-5) % 2 == -1). If this code is intending to check for oddness, consider using (x & 1) == 1, or x % 2 != 0.

Bug kind and pattern: IM - IM_BAD_CHECK_FOR_ODD

This should keep all the logic the same, just prevent this from being flagged in SpotBugs or other code checkers.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.02%. Comparing base (8dbf74b) to head (be04339).
Report is 26 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5653      +/-   ##
============================================
- Coverage     10.02%   10.02%   -0.01%     
+ Complexity     6069     6067       -2     
============================================
  Files          1074     1074              
  Lines        141609   141598      -11     
  Branches      20646    20645       -1     
============================================
- Hits          14203    14201       -2     
+ Misses       126032   126024       -8     
+ Partials       1374     1373       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.