fix: don't use floats in for loops #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use floating-point variables as loop counters Using floating-point variables should not be used as loop counters, as they are not precise, which may result in incorrect loops. A loop counter is a variable that is changed with each iteration and controls when the loop should terminate. It is decreased or increased by a fixed amount each iteration. See rule NUM09-J. Bug kind and pattern: FL - FL_FLOATS_AS_LOOP_COUNTERS
Do not use floating-point variables as loop counters Using floating-point variables should not be used as loop counters, as they are not precise, which may result in incorrect loops. A loop counter is a variable that is changed with each iteration and controls when the loop should terminate. It is decreased or increased by a fixed amount each iteration. See rule NUM09-J. Bug kind and pattern: FL - FL_FLOATS_AS_LOOP_COUNTERS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5651 +/- ##
=========================================
Coverage 10.02% 10.03%
- Complexity 6069 6075 +6
=========================================
Files 1074 1074
Lines 141609 141600 -9
Branches 20646 20645 -1
=========================================
+ Hits 14203 14216 +13
+ Misses 126032 126013 -19
+ Partials 1374 1371 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use floating-point variables as loop counters
Using floating-point variables should not be used as loop counters, as they are not precise, which may result in incorrect loops. A loop counter is a variable that is changed with each iteration and controls when the loop should terminate. It is decreased or increased by a fixed amount each iteration.
See rule NUM09-J.
Bug kind and pattern: FL - FL_FLOATS_AS_LOOP_COUNTERS
Found via SpotBugs
Also has a few other cleanups like consistency with doubles (don't use
f) and an unneeded conditional check for modulus.