Fixed Value Display in Resupplies #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated buy and sell value calculations for convoy contents to improve clarity and consistency. Updated logic to use appropriate values based on resupply type for better accuracy in determining convoy worth.
IllianiCBT
commented
Jan 4, 2025
| @@ -222,7 +224,7 @@ private static void calculateConvoyWorth(Resupply resupply) { | |||
|
|
|||
| // Smugglers always double the cost of the supplies they're offering | |||
| if (resupplyType.equals(ResupplyType.RESUPPLY_SMUGGLER)) { | |||
| resupply.setConvoyContentsValueCalculated(value.multipliedBy(2)); | |||
| resupply.setConvoyContentsValueCalculated(sellValue.multipliedBy(2)); | |||
There was a problem hiding this comment.
We use 'sell value' as that is the lower of the two valuations. We use this to ensure the user will always get a deal from employer resupplies, while (at most) getting buy value from smugglers.
We use buy value for smugglers due to the risk of being scammed. This ensures that in the event the user is scammed they're not also paying out the nose for the privilege.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5644 +/- ##
============================================
- Coverage 10.04% 10.03% -0.01%
+ Complexity 6079 6073 -6
============================================
Files 1074 1074
Lines 141598 141600 +2
Branches 20645 20645
============================================
- Hits 14221 14210 -11
- Misses 126010 126021 +11
- Partials 1367 1369 +2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resupplies were incorrectly using sell value for both resupply cost and resupply evaluation. This made it seem like resupplies were a much worse value proposition than they actually are.