Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sortable columns in the finance tab, addresses issue #4876 #5642

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

firefly2442
Copy link
Contributor

Addresses #4876

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.02%. Comparing base (8dbf74b) to head (d8a6d2f).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5642      +/-   ##
============================================
- Coverage     10.02%   10.02%   -0.01%     
  Complexity     6069     6069              
============================================
  Files          1074     1074              
  Lines        141609   141603       -6     
  Branches      20646    20645       -1     
============================================
- Hits          14203    14202       -1     
+ Misses       126032   126024       -8     
- Partials       1374     1377       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@firefly2442
Copy link
Contributor Author

Oops, hold on, this needs fixes similar to #4940.

@firefly2442 firefly2442 marked this pull request as draft January 4, 2025 20:10
@firefly2442 firefly2442 marked this pull request as ready for review January 4, 2025 20:19
@HammerGS HammerGS merged commit d33a0aa into MegaMek:master Jan 5, 2025
4 checks passed
@firefly2442 firefly2442 deleted the finance-table-sortable branch January 5, 2025 19:44
@IllianiCBT
Copy link
Collaborator

This looks like it might be causing out-of-bounds exceptions for new campaigns (any campaign with 0 transactions, I suspect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants