Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start to adjust acquisition modifiers for support vehicles, addr… #5633

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

firefly2442
Copy link
Contributor

…esses issue #5328

This should start to address the issue identified in #5328. I'm seeing the Simca unit as an example now show up as a support vehicle and not be classified as assault. However, I'm unsure what the appropriate acquisition modifiers should be. It looks like all of these probably should be reviewed as well as add any unit types that are not covered in the if-statements.

If someone can help me with a table or direct numbers, I can adjust the logic in code.

Thanks

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.03%. Comparing base (465a50e) to head (1d97590).
Report is 44 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5633      +/-   ##
============================================
- Coverage     10.04%   10.03%   -0.01%     
- Complexity     6073     6075       +2     
============================================
  Files          1074     1074              
  Lines        141557   141606      +49     
  Branches      20639    20647       +8     
============================================
- Hits          14215    14210       -5     
- Misses       125974   126019      +45     
- Partials       1368     1377       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 1ac3262 into MegaMek:master Jan 5, 2025
4 checks passed
@firefly2442 firefly2442 deleted the support-vehicles-weight branch January 5, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants