Refactored PostScenarioDialogHandler to use Generic Scenario
#5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced AtBScenario references with the generic Scenario class to enhance code flexibility and maintainability. Updated relevant method signatures and calls to align with the new parameter type. Simplified and cleaned up related code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5619 +/- ##
============================================
- Coverage 10.05% 10.05% -0.01%
- Complexity 6074 6076 +2
============================================
Files 1073 1073
Lines 141323 141321 -2
Branches 20629 20629
============================================
- Hits 14215 14212 -3
+ Misses 125740 125733 -7
- Partials 1368 1376 +8 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
AtBScenarioreferences with the genericScenarioclass to enhance code flexibility and maintainability. Updated relevant method signatures and calls to align with the new parameter type. Simplified and cleaned up related code.Fix #5615