-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds some helpful tooltips for contracts #5616
Conversation
I don't believe those '0-4' are correct. Take a look at the scenario modifiers for those command rights. iirc they use a % of the player's xBV and not fixed counts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Illiani Comments
OK thank you. I believe this is correct now? Given the XML Scenario Modifiers and looking at the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5616 +/- ##
============================================
- Coverage 10.05% 10.03% -0.03%
+ Complexity 6074 6069 -5
============================================
Files 1073 1074 +1
Lines 141323 141604 +281
Branches 20629 20645 +16
============================================
- Hits 14215 14206 -9
- Misses 125740 126023 +283
- Partials 1368 1375 +7 ☔ View full report in Codecov by Sentry. |
If you just say 'Battle Value' that'll cover both, as there is no guarantee the user has GBV enabled and it applies to both. |
You'll have to forgive me, but I can't figure out how to review on the app. However, 'contract score' isn't used any more so probably shouldn't be mentioned as that's likely to cause confusion. |
Could someone please double-check the "Command Rights" text?
Helps with user-experience (UX) and usability.