Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds some helpful tooltips for contracts #5616

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

firefly2442
Copy link
Contributor

Could someone please double-check the "Command Rights" text?

Helps with user-experience (UX) and usability.

@IllianiCBT
Copy link
Collaborator

I don't believe those '0-4' are correct. Take a look at the scenario modifiers for those command rights. iirc they use a % of the player's xBV and not fixed counts.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Illiani Comments

@firefly2442
Copy link
Contributor Author

OK thank you. I believe this is correct now? Given the XML Scenario Modifiers and looking at the ScenarioForceTemplate.java it has a forceMultiplier applied. The comments denote it adjusts it based on the Battle Value (BV) which I assume is correct and shouldn't be the General Battle Value (G)BV?

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.03%. Comparing base (559019b) to head (f9a2c20).
Report is 110 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5616      +/-   ##
============================================
- Coverage     10.05%   10.03%   -0.03%     
+ Complexity     6074     6069       -5     
============================================
  Files          1073     1074       +1     
  Lines        141323   141604     +281     
  Branches      20629    20645      +16     
============================================
- Hits          14215    14206       -9     
- Misses       125740   126023     +283     
- Partials       1368     1375       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT
Copy link
Collaborator

If you just say 'Battle Value' that'll cover both, as there is no guarantee the user has GBV enabled and it applies to both.

@IllianiCBT
Copy link
Collaborator

You'll have to forgive me, but I can't figure out how to review on the app. However, 'contract score' isn't used any more so probably shouldn't be mentioned as that's likely to cause confusion.

@firefly2442 firefly2442 requested a review from HammerGS January 4, 2025 03:48
@HammerGS HammerGS merged commit 4975aef into MegaMek:master Jan 5, 2025
4 checks passed
@firefly2442 firefly2442 deleted the contract-tooltips-ux branch January 5, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants