Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected StratCon Menu Actions for Scenario and Force Management #5610

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

IllianiCBT
Copy link
Collaborator

Revised right-click menu commands to differentiate and refine behavior for managing scenarios and reinforcements. Added checks for scenario states to ensure appropriate UI displays correctly. Previously we updated the menu behavior, however the fall through did not correctly account for situations where a scenario already existed at the location.

Fix #5608

Revised right-click menu commands to differentiate and refine behavior for managing scenarios and reinforcements. Added checks for scenario states to ensure appropriate UI displays based on context, improving user interaction clarity.
@IllianiCBT IllianiCBT added Bug StratCon Bugs relating strictly to StratCon Blocker labels Jan 2, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.04%. Comparing base (559019b) to head (b87aff9).
Report is 59 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5610      +/-   ##
============================================
- Coverage     10.05%   10.04%   -0.02%     
+ Complexity     6074     6064      -10     
============================================
  Files          1073     1073              
  Lines        141323   141331       +8     
  Branches      20629    20632       +3     
============================================
- Hits          14215    14192      -23     
- Misses       125740   125763      +23     
- Partials       1368     1376       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit e10b6cb into MegaMek:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Bug StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.03-SNAPSHOT] Unable to deploy forces to Stratcon scenarios
4 participants