Fixed NPE in ScenarioTableModel
#5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a null check for StratconCampaignState in ScenarioTableModel to prevent potential null pointer exceptions. This ensures more robust handling of scenarios without an associated campaign state.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5587 +/- ##
============================================
- Coverage 10.06% 10.05% -0.01%
+ Complexity 6079 6075 -4
============================================
Files 1073 1073
Lines 141260 141300 +40
Branches 20604 20629 +25
============================================
- Hits 14223 14213 -10
- Misses 125667 125713 +46
- Partials 1370 1374 +4 ☔ View full report in Codecov by Sentry. |
NickAragua
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a null check for
StratconCampaignStateinScenarioTableModelto prevent potential null pointer exceptions. This ensures more robust handling of scenarios without an associated campaign state.Fix #5584