Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected GUI Theme Retrieval to Use selectedTheme #5583

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

IllianiCBT
Copy link
Collaborator

Replaced direct theme retrieval from preferences with selectedTheme. This ensures that the look and feel updates correctly based on the current theme selection.

Fix #5188, #5410

Replaced direct theme retrieval from preferences with selectedTheme to improve consistency and maintainability. This ensures that the look and feel updates correctly based on the current theme selection.
@IllianiCBT IllianiCBT added the Bug label Jan 1, 2025
@IllianiCBT IllianiCBT requested a review from Sleet01 January 1, 2025 18:15
@IllianiCBT IllianiCBT self-assigned this Jan 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.06%. Comparing base (5ae9aff) to head (cfc2268).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5583      +/-   ##
============================================
- Coverage     10.06%   10.06%   -0.01%     
  Complexity     6079     6079              
============================================
  Files          1073     1073              
  Lines        141260   141299      +39     
  Branches      20604    20628      +24     
============================================
- Hits          14223    14218       -5     
- Misses       125667   125710      +43     
- Partials       1370     1371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@IllianiCBT IllianiCBT merged commit 987d6aa into MegaMek:master Jan 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(0.50.01) Theme Selection Does Not Stick
3 participants