Leadership Units & Support Point Scarcity Hot Fixes #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `StratconScenarioWizard` to support primary force-specific behavior and improved the flexibility of its UI configuration. Enhanced existing StratCon context menu commands and scenario state handling, ensuring proper state transitions and alignment with the updated wizard functionality. Also fixed array bounds handling in the skill generator to prevent potential errors.
Replaced monthly support point negotiations with weekly ones in StratCon. Updated corresponding logic, text properties, and documentation to reflect the shift to weekly intervals. This improves cadence and aligns with gameplay mechanics.
Removed unnecessary conditional check before setting up the leadership UI. This ensures consistent behavior and simplifies the code for readability and maintenance.
|
Oh and I also fixed a very rare out-of-bounds error that could occur if NPC pilots were generated with impossible skills. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5577 +/- ##
============================================
+ Coverage 10.05% 10.06% +0.01%
- Complexity 6070 6079 +9
============================================
Files 1073 1073
Lines 141258 141260 +2
Branches 20602 20604 +2
============================================
+ Hits 14203 14223 +20
+ Misses 125680 125667 -13
+ Partials 1375 1370 -5 ☔ View full report in Codecov by Sentry. |
Updated evasion logic to handle commanders without Tactics skill and refined success conditions. Modified morale scaling multipliers to improve balance and consistency. Enhanced text resources to better reflect changes in evasion outcomes.
Updated the handling of command rights by merging HOUSE and LIAISON cases. This simplifies the code and ensures consistent behavior for these scenarios.
Enhanced the calculation of maximum support points during initial negotiations by tripling the required lances. This change ensures better alignment with negotiation dynamics and provides more flexibility in initial contract setups.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The player was not correctly being shown the dialog to pick Leadership Units, or Frontline bonus units/minefields. Now they do.
Furthermore, it was found that Support Points were much scarcer than intended. Your Admin/Transport personnel will now roll three times each, at the start of the contract; and once every week (instead of every month).