Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't attempt to sum NaN tonnage equipment #5573

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

NickAragua
Copy link
Member

What it says in the title. Some spare parts in this particular warehouse have a "NaN" tonnage value ("0-shot inferno rounds"? lol), which was causing the total cargo tonnage to go to NaN, which prevented game loading.

Fix #5572

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.05%. Comparing base (d380134) to head (c691d88).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5573      +/-   ##
============================================
- Coverage     10.05%   10.05%   -0.01%     
  Complexity     6070     6070              
============================================
  Files          1073     1073              
  Lines        141257   141258       +1     
  Branches      20600    20602       +2     
============================================
- Hits          14206    14203       -3     
+ Misses       125682   125680       -2     
- Partials       1369     1375       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit cbe894d into MegaMek:master Jan 1, 2025
4 checks passed
@NickAragua NickAragua deleted the fix_cargo_stats branch January 1, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to 50.02 returning error on campaign launch
4 participants