Issue 5373: Fixed fix references not adding gunners #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5374 +/- ##
============================================
- Coverage 10.47% 10.46% -0.01%
+ Complexity 6066 6061 -5
============================================
Files 959 959
Lines 135598 135600 +2
Branches 19754 19756 +2
============================================
- Hits 14199 14196 -3
- Misses 120046 120051 +5
Partials 1353 1353 ☔ View full report in Codecov by Sentry. |
IllianiCBT
approved these changes
Dec 14, 2024
HammerGS
approved these changes
Dec 15, 2024
IllianiCBT
added a commit
to IllianiCBT/mekhq
that referenced
this pull request
Dec 15, 2024
…and-vessals-ignoring-personnel-assignments Issue 5373: Fixed fix references not adding gunners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5373
Fixes #5372
Fixes #5375
Improperly added & removed gunners originally. Verified after this fix I can load the original save from the issue correctly. I also verified I can make a new save and that it loads properly.