Issue 5333: Show Hired personnel's name change #5335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5335 +/- ##
============================================
- Coverage 10.48% 10.45% -0.03%
+ Complexity 6067 6056 -11
============================================
Files 959 959
Lines 135515 135592 +77
Branches 19743 19754 +11
============================================
- Hits 14202 14182 -20
- Misses 119957 120054 +97
Partials 1356 1356 ☔ View full report in Codecov by Sentry. |
IllianiCBT
requested changes
Dec 12, 2024
All should be resolved, thanks for taking the time to review this Illiani! |
IllianiCBT
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5333
In order to prevent confusion, when hiring personnel we will simulate their relationship history before showing their name. This lets us show their former surname if their name changed upon getting married.